fix(workspace): force-remove workspace folder with restrictive permissions#297
Conversation
Container runtimes like crun (used by Podman) can leave directories inside the workspace content folder without write permission. The standard os.RemoveAll fails on these and the error was silently discarded, leaving the workspace directory behind after delete. Add forceRemoveAll that retries removal after making all directories writable. Also log the error if removal still fails instead of silently ignoring it. Fixes: #754
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
os.RemoveAllto return permission-denied errorsforceRemoveAllincmd/agent/workspace/delete.gothat usesos.Chmodto restore write permissions on directories before removing, with fallback to direct removalcmd/agent/workspace/delete_test.goe2e/tests/down/down.gocovering delete with restrictive folder permissionsFixes skevetter/devpod#754